Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved to MultipleChoiceQuestion/MultipleChoiceEvaluation from aviary #768

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

jamesbraza
Copy link
Collaborator

We upstreamed and generalized the LitQA logic to aviary in Future-House/aviary#157.

This PR also moves the answer from GradablePaperQAEnvironment into PQASession.graded_answer for better semantic organization (within environment state instead of environment attributes).

Closes #761.

@jamesbraza jamesbraza added the enhancement New feature or request label Dec 17, 2024
@jamesbraza jamesbraza requested review from whitead and a team December 17, 2024 23:37
@jamesbraza jamesbraza self-assigned this Dec 17, 2024
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 17, 2024
Copy link
Collaborator

@mskarlin mskarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm -- looks like there are some CI issues

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
@jamesbraza jamesbraza force-pushed the aviary-qa branch 4 times, most recently from e3cd68d to 9b40b19 Compare December 19, 2024 22:39
@jamesbraza jamesbraza force-pushed the aviary-qa branch 2 times, most recently from 381b05d to 423db03 Compare January 2, 2025 21:14
@jamesbraza jamesbraza merged commit 8f73d9e into main Jan 5, 2025
5 checks passed
@jamesbraza jamesbraza deleted the aviary-qa branch January 5, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactor: Overly Complicated Question Eval
2 participants